Support extend#462
Open
sinsoku wants to merge 3 commits into
Open
Conversation
TypeProf did not handle `extend`, so methods added via `extend M` were reported as "undefined method" and `extend` was missing from the dumped RBS. Implement it symmetrically to `include`: parse Ruby/RBS `extend`, resolve the extended module's instance methods as the receiver's singleton methods, and dump `extend` for class bodies (like `include`). Self-referential `extend` (e.g. `extend self`) is still unsupported.
Passing a class object where a module it extends is expected (e.g. `App` to a `(Helpers) -> untyped` parameter) was diagnosed as "wrong type of arguments", although `App.is_a?(Helpers)` holds in Ruby. Method resolution and narrowing already recognize `extend`, so only this typecheck was inconsistent.
The extend scenarios only covered adding `extend` in an editing session. The removal direction goes through a separate code path (`remove_extend_def` and the `@extended_modules` cleanup), which had no regression guard, unlike include's remove-included-module2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeProf did not handle
extend, so methods added viaextend Mwere reported as "undefined method" andextendwas missing from the dumped RBS.Implement it symmetrically to
include: parse Ruby/RBSextend, resolve the extended module's instance methods as the receiver's singleton methods, and dumpextendfor class bodies (likeinclude).Self-referential
extend(e.g.extend self) is still unsupported.